Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snippets] Serialization/Deserialization enabled #14064

Merged
merged 50 commits into from
Nov 30, 2022
Merged

[Snippets] Serialization/Deserialization enabled #14064

merged 50 commits into from
Nov 30, 2022

Conversation

v-Golubev
Copy link
Contributor

@v-Golubev v-Golubev commented Nov 17, 2022 •
edited
Loading

Details:

  • snippets::Subgraph serialization in CPU plugin

Tickets:

  • 63594
  • 81389

vladislav-volkov and others added 28 commits March 30, 2022 15:54
@vladislav-volkov
Code snippets serialization in CPU plugin
47aad8d
@mmikolajcz
Fix Subgraph serialization
52196e1
@mmikolajcz
Merge branch 'master' of https://github.com/mmikolajcz/openvino
e88998d
@mmikolajcz
Merge branch 'master' into master
728fb1e
@mmikolajcz
Merge branch 'master' into master
7d0db54
@mmikolajcz
Fix indent alignment
d4a84a6
@mmikolajcz
Merge branch 'openvinotoolkit:master' into master
566fb5d
@mmikolajcz
Add submodule serialization test
5132f27
@mmikolajcz
Merge branch 'master' of https://github.com/mmikolajcz/openvino
6ab4a17
@mmikolajcz
Fix test
4bdf145
@mmikolajcz
Merge branch 'master' into master
fe0359c
@mmikolajcz
Move test to functional
8a9c9d0
@mmikolajcz
Merge branch 'master' into master
e284b26
@mmikolajcz
Merge branch 'master' into master
8b90f82
@mmikolajcz
Merge branch 'master' into master
d2f9ff4
@mmikolajcz
Add Scalar Constant test
9085698
@mmikolajcz
Merge branch 'master' of https://github.com/mmikolajcz/openvino
76a1d64
@mmikolajcz
Merge branch 'master' of https://github.com/openvinotoolkit/openvino
b08bb79
@mmikolajcz
Merge branch 'dev-snippets-serialization' of https://github.com/vladi…
5bc1c47 
…slav-volkov/openvino
@mmikolajcz
Fix duplication
f7e0f80
@mmikolajcz
Fix failing Snippet tests
4ab7c65
@mmikolajcz
Merge branch 'master' of https://github.com/openvinotoolkit/openvino
2a28c96
@mmikolajcz
Fix MR conflicts
1cec81a
@mmikolajcz
Add additional assert to tests
1dc0d07
@mmikolajcz
Changes requested in review
9215efa
@mmikolajcz
Merge branch 'master' into master
27cfcfd
@mmikolajcz
Use body_ptr()
6ba5a85
@mmikolajcz
Disable transformations
d2c216a
@dmitry-gorokhov dmitry-gorokhov added the category: CPU OpenVINO CPU plugin label Nov 17, 2022
@dmitry-gorokhov dmitry-gorokhov added this to the 2022.3 milestone Nov 17, 2022
@v-Golubev v-Golubev requested a review from a team as a code owner November 23, 2022 14:44
@v-Golubev
Copy link
Contributor Author

@IvanNovoselov could you please take a look again? Thanks

@v-Golubev
Copy link
Contributor Author

@ilya-lavrenov @ilyachur could you please review Core changes? Thanks

dmitry-gorokhov
dmitry-gorokhov approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please resolve remaining comments.
Also as we discussed offline test coverage should extended. Can be done in separate PR

@v-Golubev
Copy link
Contributor Author

@itikhono could you please review the changes related to the base Transformation test class? Thanks

@dmitry-gorokhov dmitry-gorokhov mentioned this pull request Nov 29, 2022
Merged
@dmitry-gorokhov
Copy link
Contributor

@ilya-lavrenov @ilyachur guys, we need your explicit approval since core part is changed

@dmitry-gorokhov dmitry-gorokhov merged commit 9eb43bb into openvinotoolkit:master Nov 30, 2022
@IvanNovoselov IvanNovoselov mentioned this pull request Nov 30, 2022
Merged
4 tasks
@andrei-kochin andrei-kochin mentioned this pull request Feb 10, 2023
Closed
@ilya-lavrenov ilya-lavrenov linked an issue Mar 1, 2023 that may be closed by this pull request
Model importing problem #12445
Closed
@ilya-lavrenov ilya-lavrenov mentioned this pull request Mar 7, 2023
Closed
@t-jankowski t-jankowski mentioned this pull request Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riverlijunjie riverlijunjie riverlijunjie left review comments

@IvanNovoselov IvanNovoselov IvanNovoselov approved these changes

@itikhono itikhono itikhono approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@ilyachur ilyachur Awaiting requested review from ilyachur

Assignees

@IvanNovoselov IvanNovoselov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2022.3
Development

Successfully merging this pull request may close these issues.

Model importing problem
9 participants
@v-Golubev @dmitry-gorokhov @ilya-lavrenov @itikhono @riverlijunjie @IvanNovoselov @vladislav-volkov @mmikolajcz @peterchen-intel